feat(providers): add webex oauth #9653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
askmrsinh
commented
Jan 16, 2024
askmrsinh
changed the title
ndom91
reviewed
Jan 21, 2024
ndom91
reviewed
Jan 23, 2024
packages/core/src/providers/webex.ts
Outdated
| params: { scope: 'spark:kms spark:people_read' } | ||
| }, | ||
| token: apiBaseUrl + '/access_token', | ||
| userinfo: apiBaseUrl + '/people/me', |
There was a problem hiding this comment.
Tiny nit on these, can you change them to string interpolation? i.e. ${apiBaseUrl}/people/me? 🙏
|
@ndom91, @ThangHuuVu - if no more changes are required, can this be merged? |
|
@askmrsinh is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi folks! The PR looks great and will greatly benefit our various Webex related projects. Would be nice if we could get this merged! |
ndom91
reviewed
Feb 8, 2024
ndom91
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Adds Webex Oauth Provider, Similarweb rank: 2,441. Used by many private/public orgs (including universities, goverment - state and federal, etc.).
🧢 Checklist
🎫 Affected issues
N/A
📌 Resources