fix(adapters): allow async SQLite clients #9355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libsql is like sqlite, and supported by drizzle, but it's a Promise-based API unlike standard SQLite which is synchronous.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
@Schniz is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
adapters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
balazsorban44
changed the title
|
Thanks for the change! Any chance that index.ts gets edited in order to accept the libsql-client and not only drizzle's BaseSQLiteDatabase? |
|
That should be a different adapter but it shouldn't be very hard to implement |
balazsorban44
had a problem deploying
to
Preview
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Drizzle supports the
@libsql/clientpackage, which is likebetter-sqlite3but Promise based. Right now, the Drizzle adapteronly works with sync code, so it's not possible to use
@libsql/clientwith it. This PR adds support for async code to theDrizzle adapter, so that
@libsql/clientcan be used with it (and therefore Turso can be used with it transitively).🧢 Checklist
🎫 Affected issues
Please scout and link issues that might be solved by this PR.
Fixes #9276, Fixes #8335, Closes #8363 (this PR adds tests too)
📌 Resources