-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: client-side baseUrl is a path #9286
fix: client-side baseUrl is a path #9286
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@tills13 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
BTW: I just want to add that the dev setup process in this repo is mint. Clone to fix took like 15 minutes. Well done. |
Co-authored-by: Balázs Orbán <[email protected]>
Hello, I've identified that this PR might be linked to an issue with the credentials provider (mentioned in issue #9309). Could someone provide some insight into the rationale behind these changes? I'm interested in understanding more to potentially contribute to a solution. Edit: After further inspection, it seems that the problem was solved by the latest commit. |
The problem still persists |
☕️ Reasoning
Maintains the existing behaviour without using baseUrl which can be either a URL (server-side) or a path (client-side). Since baseUrl is used elsewhere in the function, and the aforementioned behaviour seems to work for the rest of the function body, it seemed easier to just skip trying to make a URL out of the response when what we really wanted was just a query parameter.
🧢 Checklist
🎫 Affected issues
Please scout and link issues that might be solved by this PR.
Fixes: #9279
📌 Resources