Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client-side baseUrl is a path #9286

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

tills13
Copy link
Contributor

@tills13 tills13 commented Nov 29, 2023

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

Maintains the existing behaviour without using baseUrl which can be either a URL (server-side) or a path (client-side). Since baseUrl is used elsewhere in the function, and the aforementioned behaviour seems to work for the rest of the function body, it seemed easier to just skip trying to make a URL out of the response when what we really wanted was just a query parameter.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: #9279

📌 Resources

@tills13 tills13 requested a review from ThangHuuVu as a code owner November 29, 2023 21:36
Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 11:59am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 11:59am

Copy link

vercel bot commented Nov 29, 2023

@tills13 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@tills13
Copy link
Contributor Author

tills13 commented Nov 29, 2023

BTW: I just want to add that the dev setup process in this repo is mint. Clone to fix took like 15 minutes. Well done.

@remib18
Copy link

remib18 commented Jan 4, 2024

Hello,

I've identified that this PR might be linked to an issue with the credentials provider (mentioned in issue #9309). Could someone provide some insight into the rationale behind these changes? I'm interested in understanding more to potentially contribute to a solution.

Edit: After further inspection, it seems that the problem was solved by the latest commit.

@DevYemi
Copy link

DevYemi commented Jan 7, 2024

Hello,

I've identified that this PR might be linked to an issue with the credentials provider (mentioned in issue #9309). Could someone provide some insight into the rationale behind these changes? I'm interested in understanding more to potentially contribute to a solution.

Edit: After further inspection, it seems that the problem was solved by the latest commit.

The problem still persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V5 signin() throws error when using redirect: false
5 participants