Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): core test setup #9238

Merged
merged 8 commits into from
Nov 30, 2023
Merged

chore(test): core test setup #9238

merged 8 commits into from
Nov 30, 2023

Conversation

ThangHuuVu
Copy link
Member

@ThangHuuVu ThangHuuVu commented Nov 25, 2023 •
edited
Loading

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

In this PR, I added a vitest test setup for core.
I also write 4 tests for the session routes, including 3 tests for JWT and 1 test for DB session.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: INSERT_ISSUE_LINK_HERE

📌 Resources

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 1:58pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
auth-docs-nextra ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 1:58pm
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 1:58pm

@github-actions github-actions bot added the core Refers to `@auth/core` label Nov 25, 2023
@socket-security Socket Security
Copy link

socket-security bot commented Nov 25, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
vite 5.0.2 None +0 3.38 MB vitebot

@ThangHuuVu ThangHuuVu changed the title feat: basic test setup feat: core test setup Nov 25, 2023
balazsorban44
balazsorban44 requested changes Nov 27, 2023
View reviewed changes
packages/core/package.json Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/core/src/test-setup.ts Outdated Show resolved Hide resolved
packages/core/src/index.test.ts Outdated Show resolved Hide resolved
packages/core/src/index.test.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the core Refers to `@auth/core` label Nov 28, 2023
@ThangHuuVu ThangHuuVu marked this pull request as ready for review November 29, 2023 16:36
@ThangHuuVu ThangHuuVu requested a review from 0ubbe as a code owner November 29, 2023 16:36
@balazsorban44 balazsorban44 changed the title feat: core test setup chore(test): core test setup Nov 30, 2023
@balazsorban44 balazsorban44 merged commit 5c2b0b6 into main Nov 30, 2023
7 checks passed
@balazsorban44 balazsorban44 deleted the feat/testing-core branch November 30, 2023 13:56
liquidx pushed a commit to liquidx/next-auth that referenced this pull request Dec 4, 2023
@ThangHuuVu @liquidx
chore(test): core test setup (nextauthjs#9238)
3bf40cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@0ubbe 0ubbe Awaiting requested review from 0ubbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThangHuuVu @balazsorban44