-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider): add Dropbox #1756
feat(provider): add Dropbox #1756
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/4DxPvd7Ko8wGXgCJY3S44Puvvvrx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments, otherwise looking good! So I assume you have tested these all locally, right? Currently, we don't have any robust test setup, so we kind of rely on the ones implementing providers that they test it out before committing. 🙈
Just to note here - we need to add the new provider also to types - next-auth/types/providers.d.ts Line 56 in 55a2932
Thanks! :) |
Co-authored-by: Balázs Orbán <[email protected]>
UPDATE: Looks like it was a problem with I've made all of the suggested changes. But I'm now seeing the below error after merging main to this branch: Unhandled Runtime ErrorTypeError: Cannot use 'in' operator to search for 'undefined' in null
Call Stack
|
Co-authored-by: Adam Bergman <[email protected]>
Co-authored-by: Balázs Orbán <[email protected]> Co-authored-by: Adam Bergman <[email protected]>
What:
How:
Add provider similar to other providers.
Since dropbox does not support GET for Profile, conditionally used POST if provider is Dropbox.
Checklist: