fix validation of provider existence before looking for protection property #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/4W7Nv3eEJaC5N5mP5DzM8tJgbQaw |
balazsorban44
requested changes
Apr 11, 2021
Done, I used regular short-circuit evaluation to keep code style used on line 75. |
balazsorban44
approved these changes
Apr 11, 2021
|
That if check in line 75 is a mess... 😂 Thank you for this fix! |
|
🎉 This PR is included in version 3.14.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
5 tasks
|
🎉 This PR is included in version 4.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mnphpexpert
added a commit
to mnphpexpert/next-auth
that referenced
this pull request
Sep 2, 2024
…ty (nextauthjs#1687) * Fix validation of provider existence before looking for protection property * Use optional chaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Validate provider exists before accessing protection property in NextAuthHandler
Why:
NextAuthHandler reads all requests to api, including endpoints that does not include
providerIdas /api/auth/session, on line 73, result of finding a provider with providerId = undefined, is an undefined provider, that leads to anUnhandledPromiseRejectionWarning: TypeError: Cannot read property 'protection' of undefinedon line 82.How:
Validate provider exists before accessing protection property.
Checklist:
Fixes #1686