chore(docs): fixes appearance for some logos in dark mode #12379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@sormiston is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ndom91
approved these changes
Dec 22, 2024
ndom91
force-pushed
the
fix/dark-theme-provider-logos
branch
from
0ae8ad8 to
720668e
Compare
ndom91
changed the title
falcowinkler
pushed a commit
to halvaradop/next-auth
that referenced
this pull request
Jan 5, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This PR repairs the appearance of black provider logos (most notably Apple and Github) when presented in dark mode browser UI. These logos currently are not visible to users of dark mode.
Fix is applied via CSS on both
Auth core default signin page
Docs: Before
Docs: After
🧢 Checklist
🎫 Affected issues
This PR aims to resolve issues of #11232 .
Per @ndom91 's requirement, this solution does not require additional icons.
Rather, it inverts the color scale of specific black icons when in dark mode, with CSS.
📌 Resources