Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update twitter icon #12091

Merged
merged 3 commits into from
Feb 2, 2025
Merged

Conversation

sarthak-kumar-shailendra
Copy link
Contributor

☕️ Reasoning

The Twitter logo has been changed and hasn't been updated on the site. [Fixes #12090]
After changes
Screenshot 2024-10-22 at 12 35 58 AM
Screenshot 2024-10-22 at 12 36 10 AM

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 8:20am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2025 8:20am

Copy link

vercel bot commented Oct 21, 2024

@sarthak-kumar-shailendra is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@sarthak-kumar-shailendra
Copy link
Contributor Author

@balazsorban44 Please review

@ndom91 ndom91 changed the title fix: Updated twitter icon fix: update twitter icon Oct 28, 2024
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't directly tag the maintainers 🙏

Good catch though, thanks!

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 30 30" width="480px" height="480px"><path d="M26.37,26l-8.795-12.822l0.015,0.012L25.52,4h-2.65l-6.46,7.48L11.28,4H4.33l8.211,11.971L12.54,15.97L3.88,26h2.65 l7.182-8.322L19.42,26H26.37z M10.23,6l12.34,18h-2.1L8.12,6H10.23z"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you remove the hard coded height/width and additional extra space before 'viewBox'? Thanks!

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create a new X provider instead, and mark twitter as deprecated.

Copy link

stale bot commented Jan 21, 2025

It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks!

@stale stale bot added the stale Did not receive any activity for 60 days label Jan 21, 2025
Copy link

stale bot commented Jan 31, 2025

To keep things tidy, we are closing this issue for now. If you think your issue is still relevant, leave a comment and we might reopen it. Thanks!

@stale stale bot closed this Jan 31, 2025
@ndom91 ndom91 reopened this Feb 2, 2025
@ndom91 ndom91 merged commit 63fdab1 into nextauthjs:main Feb 2, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Did not receive any activity for 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to update twitter to x icon
3 participants