Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sveltekit): add space after provider name in SignIn btn #10225

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(sveltekit): add space after provider name in SignIn btn #10225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/frameworks-sveltekit/src/lib/components/SignIn.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,25 @@
>
<input type="hidden" name="providerId" value={provider} />
{#if callbackUrl}
<input type="hidden" name="callbackUrl" value={callbackUrl} />
<input type="hidden" name="callbackUrl" value={callbackUrl} />
{/if}
{#if redirect}
<input type="hidden" name="redirect" value={redirect} />
<input type="hidden" name="redirect" value={redirect} />
{/if}
{#if authorizationParamsInputs}
{#each Object.entries(authorizationParamsInputs) as [key, value]}
<input type="hidden" name={`authorizationParams-${key}`} value={value} />
<input type="hidden" name={`authorizationParams-${key}`} {value} />
{/each}
{/if}
{#if provider === "credentials"}
<slot name="credentials" />
{/if}
{#if provider === "email" || provider === "sendgrid" || provider === "resend"}
<slot name="email">
<label class="section-header" for={`input-email-for-${provider}-provider`}>
<label
class="section-header"
for={`input-email-for-${provider}-provider`}
>
Email
</label>
<input
Expand All @@ -60,6 +63,6 @@
</slot>
{/if}
<button type="submit">
<slot name="submitButton">Signin{provider ? `with ${provider}` : ""}</slot>
<slot name="submitButton">Signin{provider ? ` with ${provider}` : ""}</slot>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is missing in "Signin". It should be "Sign in".

</button>
</form>
Loading