fix(next-auth): cannot parse action at /session #10218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: support apps hosted on subpaths
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@bwallberg is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ndom91
approved these changes
Mar 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10218 +/- ##
==========================================
- Coverage 39.36% 39.35% -0.01%
==========================================
Files 171 171
Lines 27288 27292 +4
Branches 1159 1165 +6
==========================================
Hits 10742 10742
- Misses 16546 16550 +4 ☔ View full report in Codecov by Sentry. |
ThangHuuVu
requested changes
Mar 14, 2024
ThangHuuVu
approved these changes
Mar 16, 2024
JipSterk
pushed a commit
to JipSterk/next-auth
that referenced
this pull request
Apr 3, 2024
* fix(next-auth): cannot parse action at /session fix: support apps hosted on subpaths * refactor: use createActionURL from core directly --------- Co-authored-by: Nico Domino <[email protected]> Co-authored-by: Thang Vu <[email protected]>
JipSterk
pushed a commit
to JipSterk/next-auth
that referenced
this pull request
Apr 3, 2024
* fix(next-auth): cannot parse action at /session fix: support apps hosted on subpaths * refactor: use createActionURL from core directly --------- Co-authored-by: Nico Domino <[email protected]> Co-authored-by: Thang Vu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
All frameworks should use the core util
createActionsURL(), however sincenext-authdoesn't provide the request itself we have to rely on thex-forwarded-protoheader that next-auth sets so instead of callingcreateActionsURLdirectly we wrap it to avoid some unnecessary code duplication.Depends on #10094
🧢 Checklist
🎫 Affected issues
Fixes the original issue described in #10081
Depends on #10094
📌 Resources