Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sveltekit): use new APIs in sveltekit-example-app #10011

Merged
merged 16 commits into from
Mar 1, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Feb 12, 2024

☕️ Reasoning

  • Bring SvelteKit example app up to speed with latest API
    • Using SignIn / SignOut from @auth/sveltekit/components
    • Added /signin / /signout routes to handle server-side form actions
  • Use vite.config's server: { port: 3000 } option like sveltekit dev app, to make it easier to re-use oauth configs designed for our next.js apps
  • Cleanup the pnpm-lock situation
    • Since apps/examples/* aren't part of the pnpm workspace, they should have their own pnpm-lock.yaml and should be installed with pnpm install --ignore-workspace command

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 2:29pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 2:29pm
nextra-docs ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 2:29pm

@ndom91 ndom91 changed the title fix: udpate svelte example app to use new API fix: sveltekit-example-app to use new API Feb 12, 2024
Copy link

socket-security bot commented Feb 29, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@ndom91 ndom91 changed the title fix: sveltekit-example-app to use new API chore(sveltekit): use new APIs in sveltekit-example-app Feb 29, 2024
{$page.data.session.user?.email ?? $page.data.session.user?.name}
</span>
<SignOut>
<div class="buttonPrimary">Sign out</div>
Copy link
Member Author

@ndom91 ndom91 Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new named slot update isn't in @auth/sveltekit@latest ofc

@ndom91 ndom91 merged commit 42a6a7e into main Mar 1, 2024
12 of 13 checks passed
@ndom91 ndom91 deleted the ndom91/sveltekitauth-example-app branch March 1, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants