Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/930-extend-toNewsKitIcon-types #931

Merged
merged 6 commits into from
Jun 21, 2024
Merged

feat/930-extend-toNewsKitIcon-types #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9a3f61
feat(930): extend param types for toNewsKitIcon function
KayKostadinov May 31, 2024
68ee09f
Merge branch 'main' into feat/930-extend-toNewsKitIcon-types
KayKostadinov May 31, 2024
e87d2d1
feat(930): added disableRules to cardComposable e2e test
KayKostadinov Jun 13, 2024
5b26b29
feat(930): updated e2e lazy load image url
KayKostadinov Jun 13, 2024
c49df39
feat(930): update image url
KayKostadinov Jun 20, 2024
7dbf209
feat(930): update image url
KayKostadinov Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/generate-a11y-tests-comps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ const testsConfig = files
disabledRules = disabledRulesObj.value.elements.map(node => node.value);
}

if (title === 'cardcomposable') {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added these because the component loads dynamically brightcove video players with repeating aria IDs and this is flagged by the accessibility tests. I can see the same rules were disabled for "title": "video player" component, likely due to the same reason. Since this is loaded by a runtime script the test is flaky.

disabledRules.push('duplicate-id-aria');
disabledRules.push('duplicate-id-active');
}

return {title, disabledRules};
} catch (e) {
// eslint-disable-next-line no-console
Expand Down
5 changes: 3 additions & 2 deletions src/icons/to-newskit-icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import {EmotionIconProps} from '@emotion-icons/emotion-icon';
import {EmotionIconProps, EmotionIcon} from '@emotion-icons/emotion-icon';
import {withTheme} from '../theme';
import {NewsKitIconProps, NewsKitIcon, SvgProps} from './types';
import {getSizingCssFromTheme, getStylePreset, styled} from '../utils/style';
Expand Down Expand Up @@ -55,7 +55,8 @@ const StyledIcon = styled.svg<NewsKitIconProps>`
export const toNewsKitIcon = (
PassedIcon:
| React.ComponentType<EmotionIconProps>
| React.ComponentType<SvgProps>,
| React.ComponentType<SvgProps>
| EmotionIcon,
): NewsKitIcon =>
withOwnTheme(
withTheme<NewsKitIconProps>(
Expand Down
2 changes: 1 addition & 1 deletion src/image/__tests__/image-e2e.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const StoryE2eTest = () => (
<ImageContainer>
<p>Scroll down</p>
<Image
src="https://placekitten.com/400/400"
src="https://picsum.photos/400/400"
overrides={{width: '400px', height: '400px'}}
loadingAspectRatio="1:1"
loading="lazy"
Expand Down