-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(WWP-3314): add usnat config to consent #924
Conversation
You can preview these changes on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the docs page and a minor change is needed, but otherwise think it's looking good!
beb06c2
ec9d80b
to
beb06c2
Compare
https://nidigitalsolutions.jira.com/browse/WWP-3314
What
Background - why this is needed - Multi-State Privacy Agreement/String (MSPA) is a signal that notifies downstream partners that participating publishers have provided end-users with specific notice and choice over data processing activities on their properties. The Multi State Privacy Agreement is now available to implement on our properties alongside the U.S. Privacy String (USPS) with the intention that the MSPS will eventually supplant USPS.
What did you do - Updated
Consent
component to include the GPP stub file. Updated SP config to acceptusnat
object. This way both the new GPP string and legacy CCPA string are generated. For backwards compatibility theccpa
object is still available inConsent
config.I have done:
I have tested manually:
The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
The screen reader reads and flows through the elements as expected.
There are no new errors in the browser console coming from this PR.
When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
The Playground feature is working as expected
Before:
After:
Using current branch build locally inside
wd-web-platform
project triggersgpp
API correctly.Consent
is called with the propusnat: { includeUspApi: true }
.The cookie value for
ccpaUUID
is still present.Who should review this PR:
How to test:
Consent
component used with theusnat: { includeUspApi: true }
should trigger GPP API as shown above. This is the test function:__gpp('ping', (pingReturn, success) => {console.log('Ping request was successful: ' + success, pingReturn);});