Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(905): font metrics for djds themes publisher format #910

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Jul 12, 2023

closes #905

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

Supports both current NewsKit parsing of fontMetrics and pre-parsed fontMetrics in typographyPreset for djds-themes-publisher
@mutebg mutebg marked this pull request as ready for review July 12, 2023 15:02
@github-actions github-actions bot added the feature This change contains a new feature label Jul 12, 2023
@mutebg mutebg changed the title Feat/905 font metrics for djds themes publisher format feat(905): font metrics for djds themes publisher format Jul 13, 2023
@dj-kmuldoon dj-kmuldoon self-requested a review July 13, 2023 12:08
Copy link
Collaborator

@dj-kmuldoon dj-kmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mutebg mutebg merged commit 297d9f1 into main Jul 17, 2023
@mutebg mutebg deleted the feat/905-fontMetrics-for-djds-themes-publisher-format branch July 17, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting fontMetrics defined in typography-presets.json for Capsize functionality
4 participants