Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(898): Select panel position #899

Merged
merged 10 commits into from
Jun 26, 2023
Merged

Conversation

pdimova
Copy link

@pdimova pdimova commented Jun 12, 2023

What

Jun-26-2023.16-50-14.mp4
Jun-26-2023.16-50-19.mp4
  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the feature This change contains a new feature label Jun 12, 2023
@pp-serviceaccount
Copy link
Collaborator

@pdimova pdimova linked an issue Jun 22, 2023 that may be closed by this pull request
tbradbury
tbradbury previously approved these changes Jun 22, 2023
mutebg
mutebg previously approved these changes Jun 23, 2023
src/select/select.tsx Outdated Show resolved Hide resolved
@pdimova pdimova dismissed stale reviews from mutebg and tbradbury via dad6af8 June 26, 2023 12:04
@pdimova pdimova requested review from tbradbury and mutebg June 26, 2023 12:05
@pdimova pdimova merged commit 5c641f6 into main Jun 26, 2023
@pdimova pdimova deleted the feat/898-select-panel-position branch June 26, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Select panel open position
4 participants