Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(843): percy flaky tests #890

Merged
merged 4 commits into from
May 16, 2023
Merged

chore(843): percy flaky tests #890

merged 4 commits into from
May 16, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented May 12, 2023

closes #843

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@pp-serviceaccount
Copy link
Collaborator

@mutebg mutebg marked this pull request as ready for review May 15, 2023 14:40
@mutebg mutebg added the ready for review Please assist in getting this reviewed label May 15, 2023
@mutebg mutebg merged commit e216714 into main May 16, 2023
@mutebg mutebg deleted the chore/843-flaky-percy-tests branch May 16, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve flaky video / image Percy tests
4 participants