docs(723): Standfirst Storybook Enhancement #881
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,105 +1,154 @@ | ||||||
| import * as React from 'react'; | ||||||
| import {Standfirst} from '..'; | ||||||
| import {ThemeProvider, CreateThemeArgs} from '../../theme'; | ||||||
| import {Story as StoryType} from '@storybook/react'; | ||||||
| import {createCustomThemeWithBaseThemeSwitch} from '../../test/theme-select-object'; | ||||||
| import {StorybookCase, StorybookPage} from '../../test/storybook-comps'; | ||||||
| import {getColorCssFromTheme, styled} from '../../utils/style'; | ||||||
|
|
||||||
| const standfirstCustomThemeObject: CreateThemeArgs = { | ||||||
| name: 'my-custom-standfirst-theme', | ||||||
| overrides: { | ||||||
| stylePresets: { | ||||||
| standfirstCustom: {base: {color: '{{colors.inkBrand010}}'}}, | ||||||
| }, | ||||||
| }, | ||||||
| }; | ||||||
|
|
||||||
| const bodyString = | ||||||
| 'NewsKit provides components, guidelines and standards to enable digital product teams to create high-quality, consistent products quickly. NewsKit is built on modular design principles and backed by best practice guidance for design and development.'; | ||||||
|
|
||||||
| export const StoryDefault = () => ( | ||||||
| <StorybookPage columns="1fr"> | ||||||
| <StorybookCase> | ||||||
| <Standfirst | ||||||
| as="h2" | ||||||
| overrides={{ | ||||||
| styledText: { | ||||||
| typographyPreset: 'utilitySubheading020', | ||||||
| }, | ||||||
| }} | ||||||
| > | ||||||
| {bodyString} | ||||||
| </Standfirst> | ||||||
| </StorybookCase> | ||||||
| </StorybookPage> | ||||||
| ); | ||||||
| StoryDefault.storyName = 'Default'; | ||||||
|
|
||||||
| export const StoryWithAsSpan = () => ( | ||||||
| <StorybookPage columns="1fr"> | ||||||
| <StorybookCase> | ||||||
| <Standfirst | ||||||
| as="span" | ||||||
| overrides={{ | ||||||
| styledText: { | ||||||
| typographyPreset: 'utilitySubheading020', | ||||||
| }, | ||||||
| }} | ||||||
| > | ||||||
| {bodyString} | ||||||
| </Standfirst> | ||||||
| </StorybookCase> | ||||||
| </StorybookPage> | ||||||
| ); | ||||||
| StoryWithAsSpan.storyName = 'Standfirst as span'; | ||||||
|
|
||||||
| export const StoryLogicalProps = () => ( | ||||||
| <> | ||||||
| <StorybookPage columns="1fr"> | ||||||
| <StorybookCase> | ||||||
| <MarginOverridesWrapper> | ||||||
| <Standfirst | ||||||
| as="span" | ||||||
| overrides={{ | ||||||
| styledText: { | ||||||
| typographyPreset: 'utilitySubheading020', | ||||||
| paddingInline: '20px', | ||||||
| paddingBlock: '10px', | ||||||
| }, | ||||||
| }} | ||||||
| > | ||||||
| {bodyString} | ||||||
| </Standfirst> | ||||||
| </MarginOverridesWrapper> | ||||||
| </StorybookCase> | ||||||
| </StorybookPage> | ||||||
| </> | ||||||
| ); | ||||||
| StoryLogicalProps.storyName = 'Logical props'; | ||||||
|
|
||||||
| export const StoryWithStylingOverrides = () => ( | ||||||
| <> | ||||||
| <StorybookPage columns="1fr"> | ||||||
| <StorybookCase> | ||||||
| <Standfirst | ||||||
| as="span" | ||||||
| overrides={{ | ||||||
| styledText: { | ||||||
| typographyPreset: 'utilitySubheading020', | ||||||
| stylePreset: 'standfirstCustom', | ||||||
|
There was a problem hiding this comment. You can use directly
Suggested change
|
||||||
| }, | ||||||
| }} | ||||||
| > | ||||||
| {bodyString} | ||||||
| </Standfirst> | ||||||
| </StorybookCase> | ||||||
| </StorybookPage> | ||||||
| </> | ||||||
| ); | ||||||
| StoryWithStylingOverrides.storyName = 'Styling overrides'; | ||||||
|
|
||||||
| export const StoryWithOverrides = () => ( | ||||||
| <> | ||||||
| <StorybookPage columns="1fr"> | ||||||
| <StorybookCase title="Typography preset override"> | ||||||
| <Standfirst | ||||||
| as="span" | ||||||
| overrides={{ | ||||||
| styledText: { | ||||||
| typographyPreset: 'utilitySubheading050', | ||||||
| }, | ||||||
| }} | ||||||
| > | ||||||
| {bodyString} | ||||||
| </Standfirst> | ||||||
| </StorybookCase> | ||||||
| </StorybookPage> | ||||||
| </> | ||||||
| ); | ||||||
| StoryWithOverrides.storyName = 'Overrides'; | ||||||
|
|
||||||
| const MarginOverridesWrapper = styled.div` | ||||||
| border: 1px dashed; | ||||||
| ${getColorCssFromTheme('borderColor', 'red060')} | ||||||
| `; | ||||||
|
|
||||||
| export default { | ||||||
| title: 'Components/Standfirst', | ||||||
| component: () => 'None', | ||||||
| parameters: { | ||||||
| nkDocs: { | ||||||
| title: 'Standfirst', | ||||||
| url: 'https://www.newskit.co.uk/components/standfirst/', | ||||||
| description: | ||||||
| 'Standfirst is an introductory paragraph in an article, which summarises the articles content.', | ||||||
| }, | ||||||
| }, | ||||||
| decorators: [ | ||||||
| ( | ||||||
| Story: StoryType, | ||||||
| context: {name: string; globals: {backgrounds: {value: string}}}, | ||||||
| ) => ( | ||||||
| <ThemeProvider | ||||||
| theme={createCustomThemeWithBaseThemeSwitch( | ||||||
| context?.globals?.backgrounds?.value, | ||||||
| standfirstCustomThemeObject, | ||||||
| context?.name, | ||||||
| )} | ||||||
| > | ||||||
| <Story /> | ||||||
| </ThemeProvider> | ||||||
| ), | ||||||
| ], | ||||||
| }; | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is default I am expecting it not to have any overrides