-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(805): nx and rspack on existing project structure #847
Changes from 1 commit
411ef34
e77367a
3941dd8
77c22e9
8297a1c
02c4a01
54e9f26
ed01abe
d1abe14
2d70fff
c6ea1ca
6d5f2c5
b8c1470
b20471c
fd2a7b2
23b76b4
7ef67d3
28cd593
a2af225
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,10 +20,6 @@ | |
"passWithNoTests": true | ||
}, | ||
"configurations": { | ||
"ci": { | ||
"ci": true, | ||
"codeCoverage": true | ||
} | ||
} | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,22 @@ | ||||||||||||||||||||
{ | ||||||||||||||||||||
"extends": "../tsconfig.common.json", | ||||||||||||||||||||
"compilerOptions": { | ||||||||||||||||||||
"isolatedModules": true, | ||||||||||||||||||||
"jsx": "react", | ||||||||||||||||||||
"outDir": "../dist/cjs", | ||||||||||||||||||||
"module": "commonjs", | ||||||||||||||||||||
"types": ["jest", "node"] | ||||||||||||||||||||
}, | ||||||||||||||||||||
"include": [ | ||||||||||||||||||||
"jest.config.js", | ||||||||||||||||||||
"src/**/*.test.ts", | ||||||||||||||||||||
"src/**/*.spec.ts", | ||||||||||||||||||||
"src/**/*.test.tsx", | ||||||||||||||||||||
"src/**/*.spec.tsx", | ||||||||||||||||||||
"src/**/*.test.js", | ||||||||||||||||||||
"src/**/*.spec.js", | ||||||||||||||||||||
"src/**/*.test.jsx", | ||||||||||||||||||||
"src/**/*.spec.jsx", | ||||||||||||||||||||
Comment on lines
+12
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||
"src/**/*.d.ts" | ||||||||||||||||||||
] | ||||||||||||||||||||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,31 @@ | ||
{ | ||
"compileOnSave": false, | ||
"compilerOptions": { | ||
"rootDir": ".", | ||
"sourceMap": true, | ||
"declaration": true, | ||
"declarationMap": true, | ||
"moduleResolution": "node", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why all these new rules 🤔 ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are what the command to migrate to nx ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it might be wise to do some testing on a pre-release to check that these changes haven't had any impact on the built package. |
||
"emitDecoratorMetadata": true, | ||
"experimentalDecorators": true, | ||
"importHelpers": true, | ||
"target": "es5", | ||
"module": "commonjs", | ||
"lib": ["DOM", "ES2019"], | ||
"skipLibCheck": true, | ||
"skipDefaultLibCheck": true, | ||
"baseUrl": ".", | ||
"paths": { | ||
"@newskit/newskit/ui": ["src/index.ts"] | ||
}, | ||
"jsx": "react", | ||
"sourceMap": true, | ||
"strict": true, | ||
"strictNullChecks": true, | ||
"moduleResolution": "node", | ||
"esModuleInterop": true, | ||
"preserveSymlinks": true, | ||
"noImplicitAny": true, | ||
"resolveJsonModule": true, | ||
"isolatedModules": true, | ||
"lib": ["DOM", "ES2019"] | ||
} | ||
"isolatedModules": true | ||
}, | ||
"exclude": ["node_modules", "tmp"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given you've bumped the CI instance size should this memory size go up also?