Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(746): hide e2e tests from storybook #819

Merged
merged 6 commits into from
Apr 12, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Apr 11, 2023

#746

Closes #746

What

  1. Background - hide stories which are only for e2e testing
  2. What did you do - renamed stories as adding suffix "hidden" in that way we can target these stories with CSS selector so that they are hidden.
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Apr 11, 2023
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Apr 11, 2023
@mutebg mutebg marked this pull request as ready for review April 11, 2023 03:46
@mutebg mutebg linked an issue Apr 11, 2023 that may be closed by this pull request
@mutebg mutebg merged commit fa2e449 into main Apr 12, 2023
@mutebg mutebg deleted the docs/746-hide-e2e-tests-from-storybook branch April 12, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardise hiding e2e test stories from sidebar
4 participants