Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/ppdsc 2707 update headline component storybook scenarios #692

Merged

Conversation

jannuk59
Copy link
Contributor

@jannuk59 jannuk59 commented Mar 8, 2023

PPDSC-2707

What

Headline storybook scenario update.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 8, 2023
@jannuk59 jannuk59 marked this pull request as ready for review March 15, 2023 11:32
@jannuk59 jannuk59 requested a review from a team as a code owner March 15, 2023 11:32
JohnTParsons
JohnTParsons previously approved these changes Mar 20, 2023
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Mar 20, 2023
Copy link
Contributor

@mutebg mutebg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now looks better, but we don't have an example with kicker prop and kiker prop overrides

JohnTParsons
JohnTParsons previously approved these changes Mar 21, 2023
Comment on lines 42 to 45
marginblock: 'space030';
margininline: 'space030';
paddingblock: 'space030';
paddinginline: 'space030';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove these, they don't do anything, or you can use <Block marginBlock="space030" ... and so on

@jannuk59 jannuk59 merged commit 22b32d4 into main Mar 21, 2023
@jannuk59 jannuk59 deleted the docs/PPDSC-2707-update-headline-component-storybook-scenarios branch March 21, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants