-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PPDSC-2847): focus outlines #691
Conversation
You can preview these changes on: |
src/popover/style-presets.ts
Outdated
@@ -18,6 +19,10 @@ export default { | |||
borderRadius: '{{borders.borderRadiusDefault}}', | |||
backgroundColor: '{{colors.interface010}}', | |||
}, | |||
'focus-visible': { | |||
...defaultFocusVisible, | |||
outlineOffset: '{{borders.borderWidth000}}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use borderWidth here or do we need a new outline token like outlineWidth000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to add the token, done.
PPDSC-2847
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: