Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2847): focus outlines #691

Merged
merged 14 commits into from
Mar 14, 2023
Merged

fix(PPDSC-2847): focus outlines #691

merged 14 commits into from
Mar 14, 2023

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Mar 7, 2023

PPDSC-2847

What

  1. Background - why this is needed
  • focus-visible states for some components look strange, need to update outline offset
  1. What did you do
  • Updated outline offset for relevant components
  • Added support for negative token values (couldn't use px as there is a test to check that all style preset values are tokens)
  • Updated snapshots
  1. What does the reviewers should expect
  • Focus outlines corrected
  • No other changes

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the draft This is a draft PR and not intended for formal review yet label Mar 7, 2023
@mstuartf mstuartf requested a review from a team as a code owner March 7, 2023 17:32
@github-actions github-actions bot added the fix This change fixes a bug label Mar 7, 2023
@pp-serviceaccount
Copy link
Collaborator

@mstuartf mstuartf added ready for design review Please assist in getting this reviewed and removed draft This is a draft PR and not intended for formal review yet labels Mar 8, 2023
@mstuartf mstuartf added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Mar 10, 2023
@@ -18,6 +19,10 @@ export default {
borderRadius: '{{borders.borderRadiusDefault}}',
backgroundColor: '{{colors.interface010}}',
},
'focus-visible': {
...defaultFocusVisible,
outlineOffset: '{{borders.borderWidth000}}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use borderWidth here or do we need a new outline token like outlineWidth000

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to add the token, done.

mutebg
mutebg previously approved these changes Mar 13, 2023
@mstuartf mstuartf merged commit 58a65df into main Mar 14, 2023
@mstuartf mstuartf deleted the fix/PPDSC-2847-focus branch March 14, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants