Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2850): add next links to homepage #679

Merged
merged 12 commits into from
Mar 9, 2023
Merged

docs(PPDSC-2850): add next links to homepage #679

merged 12 commits into from
Mar 9, 2023

Conversation

Xin00163
Copy link
Contributor

@Xin00163 Xin00163 commented Feb 28, 2023 •
edited by mutebg
Loading

PPDSC-2850

  • Update homepage to use <NextLink>

  • Run broken link tests against some of the PR env to test for more broken links and update other pages that need changing

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Xin00163 Xin00163 requested a review from a team as a code owner February 28, 2023 15:52
@Xin00163 Xin00163 added the WIP Work in progress label Feb 28, 2023
@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 28, 2023
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/ppdsc-2850-homepage-links-on-pr
Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/ppdsc-2850-homepage-links-on-pr/storybook

@Xin00163 Xin00163 added ready for review Please assist in getting this reviewed and removed WIP Work in progress labels Mar 1, 2023
@Xin00163 Xin00163 requested a review from mutebg March 2, 2023 11:06
@Xin00163 Xin00163 added Waiting for Percy Waiting for monthly allowance to reset and removed ready for review Please assist in getting this reviewed labels Mar 3, 2023
@Xin00163 Xin00163 merged commit 96d9764 into main Mar 9, 2023
@Xin00163 Xin00163 deleted the docs/PPDSC-2850-homepage-links-on-pr branch March 9, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baburay23 baburay23 baburay23 approved these changes

@mutebg mutebg mutebg approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation Waiting for Percy Waiting for monthly allowance to reset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xin00163 @pp-serviceaccount @mutebg @baburay23