Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2816)update-stack-child-component-storybook-scenarios #666

Merged
merged 7 commits into from
Mar 2, 2023
Merged

docs(PPDSC-2816)update-stack-child-component-storybook-scenarios #666

merged 7 commits into from
Mar 2, 2023

Conversation

baburay23
Copy link
Contributor

PPDSC-2816

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@baburay23 baburay23 added the WIP Work in progress label Feb 24, 2023
@baburay23 baburay23 requested a review from a team as a code owner February 24, 2023 12:57
@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 24, 2023
@baburay23 baburay23 changed the title docs/PPDSC-2816-update-stack-child-component-storybook-scenarios docs(PPDSC-2816)update-stack-child-component-storybook-scenarios Feb 24, 2023
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2816-update-stack-child-component-storybook-scenarios
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2816-update-stack-child-component-storybook-scenarios/storybook

@baburay23 baburay23 added Requires design review and removed WIP Work in progress labels Feb 27, 2023
@baburay23 baburay23 added ready for review Please assist in getting this reviewed and removed Requires design review labels Mar 1, 2023
JohnTParsons
JohnTParsons approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@JohnTParsons JohnTParsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Aysha

Vanals
Vanals reviewed Mar 1, 2023
View reviewed changes
src/stack-child/__tests__/stack-child.stories.tsx
Comment on lines +13 to +15
const TagHeight = 32;
const TagWidth = 68;
const TagBorderWidth = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No magic numbers 😻

@baburay23 baburay23 changed the base branch from main to docs/PPDSC-0000-storybook-updates March 2, 2023 11:19
@baburay23 baburay23 merged commit 1c2d26e into docs/PPDSC-0000-storybook-updates Mar 2, 2023
@baburay23 baburay23 deleted the docs/PPDSC-2816-update-stack-child-component-storybook-scenarios branch March 2, 2023 11:20
mutebg added a commit that referenced this pull request Mar 10, 2023
@mutebg @evgenitsn
@baburay23 @mstuartf @jannuk59 @RashikaNewsUK @Xin00163
docs(PPDSC-0000): storybook & docs updates (#698)
54c7172 
* docs(PPDSC-2705): update grid storybook scenarios (#664)

* docs(PPDSC-2705): update grid storybook scenarious

* docs(PPDSC-2705): design review

* docs(PPDSC-2705): update bg

* docs(PPDSC-2825): update UnorderedList component storybook scenarios (#674)

* docs(PPDSC-2825): update UnorderedList component storybook scenarios

* docs(PPDSC-2825): address design comments

* docs(PPDSC-2816)update-stack-child-component-storybook-scenarios (#666)

* docs(PPDSC-2816): chore/ppdse-2816-added new stack c scenes

* docs(PPDSC-2816): chore/ppdse-2816-tidy up

* docs(PPDSC-2816): chore/ppdse-2816-addressed comments

* docs(PPDSC-2816): chore/ppdse-2816-test

* docs(PPDSC-2816): chore/ppdse-2816-removed space

* docs(PPDSC-2827): update scenarios (#668)

* docs(PPDSC-2827): update scenarios

* Docs/ppdsc 2562 content updates miscellaneous (#633)

* docs(PPDSC-2562): colours content updates

* docs(PPDSC-2562): miscellaneous - website content updates

* docs(PPDSC-2562): mobile device fonts fix

* docs(PPDSC-2562): components overview structure change

* docs(PPDSC-2562): utilties session subNav fix

* docs(PPDSC-2562): update theme/overview page

* docs(PPDSC-2562): components overview page

* docs(PPDSC-2562): utilites session implementation

* docs(PPDSC-2562): components overview page

* docs(PPDSC-2562): arialabelby fix

---------

Co-authored-by: Ravindren <[email protected]>
Co-authored-by: Stoyan Delev <[email protected]>

* Fix/ppdsc 2854 flaky tests (#680)

* fix(PPDSC-2854): don't set initial time until duration is set

* fix(PPDSC-2854): update baseline warning

* fix(PPDSC-2854): revert yarn lock changes

* Bumping to version v7.0.0 - [skip ci]

---------

Co-authored-by: jannuk59 <[email protected]>
Co-authored-by: Ravindren <[email protected]>
Co-authored-by: Stoyan Delev <[email protected]>
Co-authored-by: Product Platforms Service <[email protected]>

* docs(PPDSC-2815): update stack scenarios (#665)

* docs(PPDSC-2815): update stack scenarios

* docs(PPDSC-2815): remove variations

* docs(PPDSC-2815): correct story url

* docs(PPDSC-2815): update colours

* docs(PPDSC-2815): fix

* docs(PPDSC-2845): update image playground (#681)

* docs(PPDSC-2800) inline-message-comp-update (#684)

* docs(PPDSC-2800): docs(PPDSC-2800) inline-message-comp-updatees

* docs(PPDSC-2708): update IconButton component storybook scenarios (#682)

* docs(PPDSC-2708): update IconButton component storybook scenarios

* docs(PPDSC-2708): fix e2e

* docs(PPDSC-2708): add icon size overrides example

* docs(PPDSC-2708): extracting appearances as const

* Docs/ppdsc 2851 media query hooks message (#689)

* docs(PPDSC-2851): add inline-message to hooks page

* docs(PPDSC-2851): update texts

* docs(PPDSC-2851): update comment color in code-examples

* docs(PPDSC-2851): update snaps

* docs/PPDSC-2802: layer scenarios (#687)

* fix(PPDSC-2802): update layer scenarios

* fix(PPDSC-2802): update storybook link

* fix(PPDSC-2802): update story names

* fix(PPDSC-2802): address design comments

---------

Co-authored-by: Evgeni Nikolov <[email protected]>
Co-authored-by: baburay23 <[email protected]>
Co-authored-by: mstuartf <[email protected]>
Co-authored-by: jannuk59 <[email protected]>
Co-authored-by: Ravindren <[email protected]>
Co-authored-by: Product Platforms Service <[email protected]>
Co-authored-by: Rashika <[email protected]>
Co-authored-by: Xin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanals Vanals Vanals approved these changes

@JohnTParsons JohnTParsons JohnTParsons approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baburay23 @pp-serviceaccount @JohnTParsons @Vanals