Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2670): update title bar page #657

Merged
merged 10 commits into from
Mar 2, 2023
Merged

docs(PPDSC-2670): update title bar page #657

merged 10 commits into from
Mar 2, 2023

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Feb 20, 2023 •
edited by jira bot
Loading

PPDSC-2670

What

  1. Background - why this is needed
  • Upgrade title bar docs
  1. What did you do
  2. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Feb 20, 2023
@mstuartf mstuartf requested a review from a team as a code owner February 20, 2023 18:23
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2670-title
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2670-title/storybook

@mstuartf mstuartf added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Feb 27, 2023
baburay23
baburay23 previously approved these changes Feb 28, 2023
View reviewed changes
mutebg
mutebg previously approved these changes Mar 2, 2023
View reviewed changes
baburay23
baburay23 previously approved these changes Mar 2, 2023
View reviewed changes
@mstuartf mstuartf dismissed stale reviews from baburay23 and mutebg via 765ac2d March 2, 2023 12:53
mutebg
mutebg previously approved these changes Mar 2, 2023
View reviewed changes
baburay23
baburay23 previously approved these changes Mar 2, 2023
View reviewed changes
@mstuartf mstuartf dismissed stale reviews from baburay23 and mutebg via 73676c6 March 2, 2023 13:34
@mstuartf mstuartf merged commit 82952bd into main Mar 2, 2023
@mstuartf mstuartf deleted the docs/PPDSC-2670-title branch March 2, 2023 14:30
JohnTParsons pushed a commit that referenced this pull request Mar 7, 2023
@mstuartf
docs(PPDSC-2670): update title bar page (#657)
0e3c416 
* docs(PPDSC-2670): update title bar page

* docs(PPDSC-2670): fixes

* docs(PPDSC-2670): fix heading link

* docs(PPDSC-2670): correct images

* docs(PPDSC-2670): fixes

* docs(PPDSC-2670): change heading size

* docs(PPDSC-2670): logical props

* docs(PPDSC-2670): new link component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baburay23 baburay23 baburay23 approved these changes

@mutebg mutebg mutebg approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mstuartf @pp-serviceaccount @mutebg @baburay23