Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2830): fix logo rerendering on home page #626

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

jps
Copy link
Contributor

@jps jps commented Feb 10, 2023

PPDSC-2830

What

  1. Background - why this is needed, the logo was rerendering on state update
  2. What did you do, moved into it's own sub component
  3. What does the reviewers should expect, the logo shouldn't rerender

I have done:

  • [] Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@jps jps requested a review from a team as a code owner February 10, 2023 16:07
@github-actions github-actions bot added the fix This change fixes a bug label Feb 10, 2023
@jps jps changed the title fix(PPDSC-2830): update readme fix(PPDSC-2830): fix logo rerendering on home page Feb 13, 2023
@jps jps added docs Improvements or additions to documentation and removed fix This change fixes a bug labels Feb 13, 2023
@JohnTParsons JohnTParsons added the ready for review Please assist in getting this reviewed label Feb 14, 2023
@jps jps merged commit f8f6926 into main Feb 14, 2023
@jps jps deleted the fix/PPDSC-2830-fix-homepage-re-renders branch February 14, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants