Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2712): circle remote docker has no space left #623

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

Xin00163
Copy link
Contributor

PPDSC-2712

https://app.circleci.com/pipelines/github/newscorp-ghfb/newskit/5873/workflows/55be43c4-206e-4767-8c18-34a761856b01/jobs/123993 failed on “deploy_terraform_s3_dev” step due to “"Error pulling image newsuk/terraform:1.2.1: failed to register layer: Error processing tar file(exit status 1): write /usr/lib/x86_64-linux-gnu/libwebp.so.7.1.3: no space left on device... retrying image cache not found on this host, downloading newsuk/terraform:1.2.1"

Having read this: Disk space limited in docker image using resource_class: large may solve the issue.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Xin00163 Xin00163 requested a review from a team as a code owner February 10, 2023 09:17
@github-actions github-actions bot added the fix This change fixes a bug label Feb 10, 2023
@Xin00163 Xin00163 added ready for review Please assist in getting this reviewed and removed fix This change fixes a bug labels Feb 10, 2023
@Xin00163 Xin00163 merged commit 6dd4b54 into main Feb 10, 2023
@Xin00163 Xin00163 deleted the fix/PPDSC-2712-terraform-docker-no-space-left branch February 10, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants