Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(PPDSC-2771): circleci work for dev k8s to s3 migration #603

Merged
merged 15 commits into from
Feb 8, 2023

Conversation

JohnTParsons
Copy link
Collaborator

@JohnTParsons JohnTParsons commented Feb 3, 2023

PPDSC-2771

What

  1. Background - k8s not as reliable or simple to configure as s3, plus required to migrate to OIDC by mid-year
  2. What did you do - first created a role in cloud native repo with s3 permissions, etc.
  3. What does the reviewers should expect. After a merge
    http://ncu-newskit-docs-dev.s3-website-eu-west-1.amazonaws.com/ should contain latest docs site from main branch
    http://ncu-newskit-docs-dev.s3-website-eu-west-1.amazonaws.com/storybook should contain latest storybook from main branch

These files have been deployed to prove that latest version is being served:
http://ncu-newskit-docs-dev.s3-website-eu-west-1.amazonaws.com/timestamp.html
http://ncu-newskit-docs-dev.s3-website-eu-west-1.amazonaws.com/storybook/timestamp.html
(cmd-R in browser may be need to force refresh - if calling via the CDN dev endpoint, the files will refresh automatically).

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:
Merge this PR!

In the corresponding spike branch, the technique was tested by making the deployment happen on every git push.

@pp-serviceaccount
Copy link
Collaborator

@JohnTParsons JohnTParsons marked this pull request as ready for review February 6, 2023 08:54
@JohnTParsons JohnTParsons requested a review from a team as a code owner February 6, 2023 08:54
@JohnTParsons JohnTParsons added the ready for review Please assist in getting this reviewed label Feb 6, 2023
@LukeFinch LukeFinch changed the title ci(PPDSC-2771): circleci work for dev 8s to s3 migration ci(PPDSC-2771): circleci work for dev k8s to s3 migration Feb 6, 2023
terraform/s3/README.md Show resolved Hide resolved
terraform/s3/README.md Outdated Show resolved Hide resolved
terraform/s3/README.md Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@JohnTParsons JohnTParsons merged commit fcc80ad into main Feb 8, 2023
@JohnTParsons JohnTParsons deleted the ci/PPDSC-2771 branch February 8, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants