Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2675): speed up unit tests local run #600

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

Xin00163
Copy link
Contributor

@Xin00163 Xin00163 commented Feb 2, 2023

PPDSC-2675

What I have done:

  • Fix the disabled state in svg-previewer.tsx
  • Update svg-previewer.test.tsx
  • Update outdated docsite unit tests
  • Increase local run maxWorker to 50% (this command is optional as not everyone wants to use 50%)

But if it's enabled, there is a dramatic difference:

Before:
Screenshot 2023-02-01 at 10 33 49

After:
Screenshot 2023-02-02 at 17 51 54

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Xin00163 Xin00163 requested a review from a team as a code owner February 2, 2023 18:00
@pp-serviceaccount
Copy link
Collaborator

@Xin00163 Xin00163 changed the title chore(PPDSC-2675): speed unit tests local run chore(PPDSC-2675): speed up unit tests local run Feb 2, 2023
evgenitsn
evgenitsn previously approved these changes Feb 3, 2023
@Xin00163 Xin00163 added the ready for review Please assist in getting this reviewed label Feb 3, 2023
Copy link
Collaborator

@JohnTParsons JohnTParsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I don't think you should be changing yarn.lock though as package.json has not changed

@Xin00163
Copy link
Contributor Author

Xin00163 commented Feb 3, 2023

Good work. I don't think you should be changing yarn.lock though as package.json has not changed

I ran yarn upgrade interactive to upgrade the testing library package, which clearly was not needed. Now I need to revert it back

@Xin00163 Xin00163 merged commit a751bd9 into main Feb 6, 2023
@Xin00163 Xin00163 deleted the chore/PPDSC-2675-unit-tests-slow branch February 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants