Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2517): update TextField component scenarios #587

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2517

What

Background - updating the Storybook scenarios
What did you do - updated TextField component scenarios
What does the reviewers should expect - new stories for TextField

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:
image

After:
image

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Jan 25, 2023
@evgenitsn evgenitsn requested a review from a team as a code owner January 25, 2023 12:07
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Jan 25, 2023
@evgenitsn evgenitsn merged commit 66d4f49 into main Jan 27, 2023
@evgenitsn evgenitsn deleted the docs/PPDSC-2517-update-text-field-component-scenarios branch January 27, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants