Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2664): byline documentation #578

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2664

What

New documentation page for Byline

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Jan 23, 2023
@evgenitsn evgenitsn requested a review from a team as a code owner January 23, 2023 08:42
@pp-serviceaccount
Copy link
Collaborator

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Jan 23, 2023
},
],
},
// eslint-disable-next-line @typescript-eslint/no-explicit-any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the Playground gave me a lot of type issues too. So I made some changes in my PR to hopefully avoid having to do this kind of thing from now on. But for now I think this is required.

@evgenitsn evgenitsn merged commit c55e218 into main Jan 24, 2023
@evgenitsn evgenitsn deleted the docs/PPDSC-2664-byline-documentation branch January 24, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants