Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2659): update breadcrumb icon to use margin instead of padding #575

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Jan 20, 2023

PPDSC-2659

What

  1. Background - padding work differently depending on box-sizing, in our storybook is different from our website. That causes issues on our docs site ( and probably to our users )
  2. What did you do - changed padding to margin.
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the fix This change fixes a bug label Jan 20, 2023
@mutebg mutebg marked this pull request as ready for review January 20, 2023 08:26
@mutebg mutebg requested a review from a team as a code owner January 20, 2023 08:26
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Jan 20, 2023
@pp-serviceaccount
Copy link
Collaborator

@baburay23 baburay23 self-requested a review January 23, 2023 10:29
@mutebg mutebg merged commit 58da12d into main Jan 23, 2023
@mutebg mutebg deleted the fix/PPDSC-2659-breadcrumb-icons branch January 23, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants