Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2696): set default padding block to 'space000' for breadCrumbItem #565

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

Xin00163
Copy link
Contributor

@Xin00163 Xin00163 commented Jan 17, 2023

PPDSC-2696

The breadcrumb item currently has padding top and bottom (inherited from the Button).
This needs to be removed. There already is a paddingInline: 'space000' but need the same for paddingBlock

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@Xin00163 Xin00163 requested a review from a team as a code owner January 17, 2023 14:23
@github-actions github-actions bot added the feature This change contains a new feature label Jan 17, 2023
@Xin00163 Xin00163 added the ready for review Please assist in getting this reviewed label Jan 17, 2023
@Xin00163 Xin00163 merged commit 3426cb2 into main Jan 18, 2023
@Xin00163 Xin00163 deleted the feat/PPDSC-2696-remove-padding-from-breadCrumbItem branch January 18, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants