Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2653): fix console errors on homepage #544

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

evgenitsn
Copy link
Contributor

@evgenitsn evgenitsn commented Jan 5, 2023

PPDSC-2653

What

  1. Background - There was a few console errors and warning on the docs home page
  2. What did you do - Fixed them
  3. What does the reviewers should expect - No errors in the browser console on home page

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added fix This change fixes a bug docs Improvements or additions to documentation ready for review Please assist in getting this reviewed labels Jan 5, 2023
@evgenitsn evgenitsn requested a review from a team as a code owner January 5, 2023 08:04
JohnTParsons
JohnTParsons previously approved these changes Jan 5, 2023
@baburay23 baburay23 self-requested a review January 9, 2023 16:25
@evgenitsn evgenitsn merged commit 3444454 into main Jan 10, 2023
@evgenitsn evgenitsn deleted the docs/PPDSC-2653-fix-console-errors-on-homepage branch January 10, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants