Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2614): make sure gh cli initialized #541

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Jan 4, 2023

PPDSC-2614

What

  1. Background - why this is needed
  • main job to update percy baselines failing
  1. What did you do
  • make sure gh cli is initialized
  1. What does the reviewers should expect
  • percy baselines should update when required

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf requested a review from a team as a code owner January 4, 2023 10:45
@newskit-engineering
Copy link
Collaborator

@baburay23 baburay23 self-requested a review January 4, 2023 11:14
@mstuartf mstuartf merged commit 0ded917 into main Jan 4, 2023
@mstuartf mstuartf deleted the chore/PPDSC-2614-init-cli branch January 4, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants