Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2512): component statuses #533

Merged
merged 8 commits into from
Jan 5, 2023

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Jan 3, 2023

PPDSC-2512

What

  1. Background - why this is needed
  • Some component statuses on the doc site are out of date (e.g. deprecated components listed as supported)
  1. What did you do
  2. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the draft This is a draft PR and not intended for formal review yet label Jan 3, 2023
@mstuartf mstuartf requested a review from a team as a code owner January 3, 2023 12:48
@newskit-engineering
Copy link
Collaborator

@JohnTParsons
Copy link
Collaborator

Code looks ok but ci/circleci: test_unit_docs is failing

@mstuartf mstuartf changed the title Chore/ppdsc 2512 component statuses chore(PPDSC-2512): component statuses Jan 3, 2023
@mstuartf
Copy link
Contributor Author

mstuartf commented Jan 4, 2023

Code looks ok but ci/circleci: test_unit_docs is failing

@JohnTParsons yep, I started with a test script and pushed to verify that it would fail (the PR is still in draft). Just checking everything over and will move to ready_for_review shortly.

@mstuartf mstuartf added ready for review Please assist in getting this reviewed docs Improvements or additions to documentation and removed draft This is a draft PR and not intended for formal review yet labels Jan 4, 2023
@mstuartf mstuartf merged commit 68b75de into main Jan 5, 2023
@mstuartf mstuartf deleted the chore/PPDSC-2512-component-statuses branch January 5, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants