Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2592): remove all unused .tsx illustrations #526

Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2592

What
Removing all old .tsx files which are no longer used
Also removed the tsx to svg convertor script because it is no longer needed.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed task A non user facing change labels Dec 19, 2022
@evgenitsn evgenitsn requested a review from a team as a code owner December 19, 2022 13:38
@evgenitsn evgenitsn merged commit 4e15f2c into main Dec 20, 2022
@evgenitsn evgenitsn deleted the chore/PPDSC-2592-remove-unused-tsx-illustrations-from-docs branch December 20, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed task A non user facing change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants