Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2561) Update titles in Usage section on site to support custom titles #524

Merged
merged 9 commits into from
Dec 22, 2022

Conversation

RashikaNewsUK
Copy link
Contributor

PPDSC-2561

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@RashikaNewsUK RashikaNewsUK added docs Improvements or additions to documentation feature This change contains a new feature labels Dec 16, 2022
@RashikaNewsUK RashikaNewsUK requested a review from a team as a code owner December 16, 2022 09:58
@RashikaNewsUK RashikaNewsUK force-pushed the docs/PPDSC-2561-update-usage-section-in-docs branch from df27f5d to c9d8d9a Compare December 16, 2022 10:23
@RashikaNewsUK RashikaNewsUK force-pushed the docs/PPDSC-2561-update-usage-section-in-docs branch from 4a96414 to c089bfe Compare December 16, 2022 11:00
@RashikaNewsUK RashikaNewsUK force-pushed the docs/PPDSC-2561-update-usage-section-in-docs branch from 321cd81 to b7c8b38 Compare December 16, 2022 11:27
@RashikaNewsUK RashikaNewsUK added ready for design review Please assist in getting this reviewed task A non user facing change enhancement New feature or request and removed feature This change contains a new feature labels Dec 16, 2022
@RashikaNewsUK RashikaNewsUK added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Dec 21, 2022
JohnTParsons
JohnTParsons previously approved these changes Dec 21, 2022
@RashikaNewsUK RashikaNewsUK force-pushed the docs/PPDSC-2561-update-usage-section-in-docs branch from f51e0d6 to bd54848 Compare December 21, 2022 10:39
@baburay23 baburay23 self-requested a review December 22, 2022 09:02
@RashikaNewsUK RashikaNewsUK merged commit 9d911d7 into main Dec 22, 2022
@RashikaNewsUK RashikaNewsUK deleted the docs/PPDSC-2561-update-usage-section-in-docs branch December 22, 2022 09:37
@RashikaNewsUK RashikaNewsUK removed the ready for review Please assist in getting this reviewed label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement New feature or request task A non user facing change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants