-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(PPDSC-2601): update Accordion component storybook scenarios #519
docs(PPDSC-2601): update Accordion component storybook scenarios #519
Conversation
You can preview these changes on: |
…torybook-scenarios
…torybook-scenarios
…torybook-scenarios
@@ -17,6 +17,7 @@ import { | |||
} from '../src/instrumentation'; | |||
|
|||
const unlimitedScenarios = [ | |||
'Accordion', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is still needed, but is something we can discuss with Mike when is back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added it because one of the story pages was with too long height and it was getting cut off because of the overflow: hidden
. This way by adding it here this is fixed. If we are not constrained by page height for Percy I think we can just remove the logic for fixed height and overflow hidden so that every scenario is a "unlimited" scenario. But yeah, worth discussing with Mike.
…torybook-scenarios
PPDSC-2601
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: