Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2557): update Byline component storybook scenarios #511

Merged

Conversation

evgenitsn
Copy link
Contributor

@evgenitsn evgenitsn commented Dec 8, 2022

PPDSC-2557

What

  1. Background - updating the Storybook scenarios
  2. What did you do - updated Byline component scenarios
  3. What does the reviewers should expect - new stories for Byline

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:
image

After:
image

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Dec 8, 2022
@evgenitsn evgenitsn requested a review from a team as a code owner December 8, 2022 06:39
@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Dec 8, 2022
@baburay23 baburay23 self-requested a review December 13, 2022 10:30
@evgenitsn evgenitsn merged commit d055987 into main Dec 13, 2022
@evgenitsn evgenitsn deleted the docs/PPDSC-2557-update-byline-component-storybook-scenarios branch December 13, 2022 14:34
JohnTParsons added a commit that referenced this pull request Dec 20, 2022
* refactor(PPDSC-2606): update feature card component & copy

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: baburay23 <[email protected]>

* chore(DEPS): bump qs from 6.5.2 to 6.5.3 (#508)

Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.5.2...v6.5.3)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: baburay23 <[email protected]>

* docs(PPDSC-2627): docs(PPDSC-2627) updated overrides in doc sites (#516)

updated overrides in doc site

* chore(DEPS): bump express from 4.17.1 to 4.18.2 (#513)

Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.17.1...4.18.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: baburay23 <[email protected]>

* docs(PPDSC-2557): update Byline component storybook scenarios (#511)

* refactor(PPDSC-2606): new release feature card

* refactor(PPDSC-2606): fix styling issues from design review

* refactor(PPDSC-2606): refactor featurecard props

* refactor(PPDSC-2606): remove interactivity; standardise border radius

* refactor(PPDSC-2606): fix merge conflict

* refactor(PPDSC-2606): remove leftovers

* refactor(PPDSC-2606): link*Persistent to site/theme/style-presets.ts

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: John Parsons <[email protected]>
Co-authored-by: Evgeni Nikolov <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: baburay23 <[email protected]>
Co-authored-by: Rashika <[email protected]>
Co-authored-by: JohnTParsons <JohnTParsons>
Co-authored-by: Marco Vanali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants