Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PPDSC-2622): update CODEOWNERS #500

Merged
merged 7 commits into from
Nov 30, 2022

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2622

What

Update CODEOWNERS to use @team instead of manually updating usernames.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@newskit-engineering
Copy link
Collaborator

@evgenitsn evgenitsn added task A non user facing change ready for review Please assist in getting this reviewed labels Nov 30, 2022
@evgenitsn evgenitsn merged commit f877f12 into main Nov 30, 2022
@evgenitsn evgenitsn deleted the chore/PPDSC-2622-update-codeowners branch November 30, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed task A non user facing change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants