-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(PPDSC-2481): add marketwatch and wsj themes #492
Conversation
You can preview these changes on: |
.storybook/fetch-external-fonts.js
Outdated
fontFamily: "Retina", | ||
sources: [ | ||
`${fontCdnWSJ}/woffs/retina/Retina-BookItalic.woff2`, | ||
`${fontCdnWSJ}/woffs/retina/Retina-BookItalic.woff`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should get rid of woff
files, they just make noise, all modern browsers support woff2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the one you just removed, do you need to also update the @font-face? I think some are still looking for woff
file even now we are not downloading it anymore!
I would maybe then just double check everything still looks good, but should be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
PPDSC-2481
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: