Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/PPDSC-2560 percy config #467

Merged
merged 6 commits into from
Nov 14, 2022
Merged

Fix/PPDSC-2560 percy config #467

merged 6 commits into from
Nov 14, 2022

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Nov 8, 2022

PPDSC-2560

What

  1. Background - percy tests out of sync with applitools
  2. What did you do - added missing skips and aligned docsite test logic
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

- Set dark theme on load for dark theme test
- Ignore (dynamic) version badge on welcome page
@mstuartf mstuartf added the fix This change fixes a bug label Nov 8, 2022
@newskit-engineering
Copy link
Collaborator

@mstuartf mstuartf force-pushed the fix/PPDSC-2560-percy-config branch from a9bd810 to c724236 Compare November 9, 2022 14:20
@mstuartf mstuartf changed the title Fix/PPDSC-2560 percy docsite config Fix/PPDSC-2560 percy config Nov 9, 2022
@mstuartf mstuartf added the ready for review Please assist in getting this reviewed label Nov 9, 2022
@mstuartf mstuartf merged commit 347b250 into main Nov 14, 2022
@mstuartf mstuartf deleted the fix/PPDSC-2560-percy-config branch November 14, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants