Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PPDSC-2523): sub menu component #464

Merged
merged 20 commits into from
Nov 11, 2022
Merged

feat(PPDSC-2523): sub menu component #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f4fc8fa
chore(PPDSC-2523): pull code from spike
Xin00163 Nov 2, 2022
d4dbc63
fix(PPDSC-2523): clean up code in spike
Xin00163 Nov 3, 2022
21c8cf6
fix(PPDSC-2523): merge main
Xin00163 Nov 4, 2022
9f90e23
chore(PPDSC-2523): update storybook
Xin00163 Nov 4, 2022
166e942
fix(PPDSC-2523): remove redundant width:100%
Xin00163 Nov 4, 2022
a00097d
fix(PPDSC-2523): update stories and tests
Xin00163 Nov 7, 2022
49c07f5
fix(PPDSC-2523): a11y tests
Xin00163 Nov 8, 2022
01af28b
Merge branch 'main' into feat/PPDSC-2523-sub-menu-component
Xin00163 Nov 8, 2022
c8d9581
fix(PPDSC-2523): update stories
Xin00163 Nov 9, 2022
f2c8346
fix(PPDSC-2523): update stories
Xin00163 Nov 9, 2022
f4cc843
Merge branch 'main' into feat/PPDSC-2523-sub-menu-component
Xin00163 Nov 9, 2022
f940f78
feat(PPDSC-2523): add extra demo
Nov 9, 2022
d0430a7
fix(PPDSC-2523): align stories
Xin00163 Nov 9, 2022
0646c64
fix(PPDSC-2523): build e2e
Xin00163 Nov 9, 2022
abea116
fix(PPDSC-2523): address comments
Xin00163 Nov 10, 2022
69358e5
fix(PPDSC-2523): address comments
Xin00163 Nov 10, 2022
4f821ca
fix(PPDSC-2523): apply selected state
Xin00163 Nov 11, 2022
e7174b8
fix(PPDSC-2523): remove menuSub defaults
Xin00163 Nov 11, 2022
618271e
Merge branch 'main' into feat/PPDSC-2523-sub-menu-component
Xin00163 Nov 11, 2022
bbc7bfe
Merge branch 'main' into feat/PPDSC-2523-sub-menu-component
Xin00163 Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions site/components/__tests__/__snapshots__/site-header.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,7 @@ exports[`SiteHeader has first item highlighted (About) if we are on a section wi

.emotion-141>ul {
box-sizing: border-box;
position: relative;
list-style-type: none;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -1015,14 +1016,13 @@ exports[`SiteHeader has first item highlighted (About) if we are on a section wi
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 80px;
min-height: 80px;
box-sizing: border-box;
-webkit-text-decoration: none;
text-decoration: none;
min-height: 80px;
min-width: auto;
min-width: 80px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -1037,6 +1037,7 @@ exports[`SiteHeader has first item highlighted (About) if we are on a section wi
border-width: 4px;
border-style: solid;
cursor: pointer;
width: 100%;
color: #3358CC;
-webkit-text-decoration: none;
text-decoration: none;
Expand Down Expand Up @@ -1148,14 +1149,13 @@ exports[`SiteHeader has first item highlighted (About) if we are on a section wi
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 80px;
min-height: 80px;
box-sizing: border-box;
-webkit-text-decoration: none;
text-decoration: none;
min-height: 80px;
min-width: auto;
min-width: 80px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -1170,6 +1170,7 @@ exports[`SiteHeader has first item highlighted (About) if we are on a section wi
border-width: 4px;
border-style: solid;
cursor: pointer;
width: 100%;
-webkit-box-pack: center;
-ms-flex-pack: center;
-webkit-justify-content: center;
Expand Down Expand Up @@ -4030,6 +4031,7 @@ exports[`SiteHeader has first item highlighted (About) if we are on the /about s

.emotion-141>ul {
box-sizing: border-box;
position: relative;
list-style-type: none;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -4069,14 +4071,13 @@ exports[`SiteHeader has first item highlighted (About) if we are on the /about s
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 80px;
min-height: 80px;
box-sizing: border-box;
-webkit-text-decoration: none;
text-decoration: none;
min-height: 80px;
min-width: auto;
min-width: 80px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -4091,6 +4092,7 @@ exports[`SiteHeader has first item highlighted (About) if we are on the /about s
border-width: 4px;
border-style: solid;
cursor: pointer;
width: 100%;
color: #3358CC;
-webkit-text-decoration: none;
text-decoration: none;
Expand Down Expand Up @@ -4202,14 +4204,13 @@ exports[`SiteHeader has first item highlighted (About) if we are on the /about s
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 80px;
min-height: 80px;
box-sizing: border-box;
-webkit-text-decoration: none;
text-decoration: none;
min-height: 80px;
min-width: auto;
min-width: 80px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -4224,6 +4225,7 @@ exports[`SiteHeader has first item highlighted (About) if we are on the /about s
border-width: 4px;
border-style: solid;
cursor: pointer;
width: 100%;
-webkit-box-pack: center;
-ms-flex-pack: center;
-webkit-justify-content: center;
Expand Down Expand Up @@ -7084,6 +7086,7 @@ exports[`SiteHeader has no highlighted items if we are on the homepage 1`] = `

.emotion-141>ul {
box-sizing: border-box;
position: relative;
list-style-type: none;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -7123,14 +7126,13 @@ exports[`SiteHeader has no highlighted items if we are on the homepage 1`] = `
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 80px;
min-height: 80px;
box-sizing: border-box;
-webkit-text-decoration: none;
text-decoration: none;
min-height: 80px;
min-width: auto;
min-width: 80px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -7145,6 +7147,7 @@ exports[`SiteHeader has no highlighted items if we are on the homepage 1`] = `
border-width: 4px;
border-style: solid;
cursor: pointer;
width: 100%;
-webkit-box-pack: center;
-ms-flex-pack: center;
-webkit-justify-content: center;
Expand Down
30 changes: 18 additions & 12 deletions site/components/sidebar/__tests__/__snapshots__/sidebar-navigation.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ exports[`Sidebar navigation should match snapshot with active link 1`] = `

.emotion-1>ul {
box-sizing: border-box;
position: relative;
list-style-type: none;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -290,15 +291,14 @@ exports[`Sidebar navigation should match snapshot with active link 1`] = `
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 64px;
min-height: 40px;
padding-inline: 64px;
box-sizing: border-box;
-webkit-text-decoration: none;
text-decoration: none;
min-height: 40px;
min-width: auto;
min-width: 64px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -313,6 +313,7 @@ exports[`Sidebar navigation should match snapshot with active link 1`] = `
border-style: solid;
color: #5A6A79;
cursor: pointer;
width: 100%;
-webkit-text-decoration: none;
text-decoration: none;
border-color: transparent transparent transparent #3358CC;
Expand Down Expand Up @@ -442,15 +443,14 @@ exports[`Sidebar navigation should match snapshot with active link 1`] = `
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 64px;
min-height: 40px;
padding-inline: 64px;
box-sizing: border-box;
-webkit-text-decoration: none;
text-decoration: none;
min-height: 40px;
min-width: auto;
min-width: 64px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -465,6 +465,7 @@ exports[`Sidebar navigation should match snapshot with active link 1`] = `
border-style: solid;
color: #5A6A79;
cursor: pointer;
width: 100%;
-webkit-box-pack: start;
-ms-flex-pack: start;
-webkit-justify-content: flex-start;
Expand Down Expand Up @@ -782,6 +783,7 @@ exports[`Sidebar navigation should match snapshot with active link 1`] = `

.emotion-1>ul {
box-sizing: border-box;
position: relative;
list-style-type: none;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -824,7 +826,6 @@ exports[`Sidebar navigation should match snapshot with active link 1`] = `
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 64px;
min-height: 40px;
-webkit-padding-start: 32px;
Expand All @@ -833,7 +834,7 @@ exports[`Sidebar navigation should match snapshot with active link 1`] = `
-webkit-text-decoration: none;
text-decoration: none;
min-height: 40px;
min-width: auto;
min-width: 64px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -848,6 +849,7 @@ exports[`Sidebar navigation should match snapshot with active link 1`] = `
border-style: solid;
color: #5A6A79;
cursor: pointer;
width: 100%;
-webkit-box-pack: start;
-ms-flex-pack: start;
-webkit-justify-content: flex-start;
Expand Down Expand Up @@ -993,6 +995,7 @@ exports[`Sidebar navigation should match snapshot with no active link 1`] = `

.emotion-1>ul {
box-sizing: border-box;
position: relative;
list-style-type: none;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -1244,15 +1247,14 @@ exports[`Sidebar navigation should match snapshot with no active link 1`] = `
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 64px;
min-height: 40px;
padding-inline: 64px;
box-sizing: border-box;
-webkit-text-decoration: none;
text-decoration: none;
min-height: 40px;
min-width: auto;
min-width: 64px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -1267,6 +1269,7 @@ exports[`Sidebar navigation should match snapshot with no active link 1`] = `
border-style: solid;
color: #5A6A79;
cursor: pointer;
width: 100%;
-webkit-box-pack: start;
-ms-flex-pack: start;
-webkit-justify-content: flex-start;
Expand Down Expand Up @@ -1651,6 +1654,7 @@ exports[`Sidebar navigation should match snapshot with no active link 1`] = `

.emotion-1>ul {
box-sizing: border-box;
position: relative;
list-style-type: none;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -1731,6 +1735,7 @@ exports[`Sidebar navigation should render only routes under current section 1`]

.emotion-1>ul {
box-sizing: border-box;
position: relative;
list-style-type: none;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -1982,15 +1987,14 @@ exports[`Sidebar navigation should render only routes under current section 1`]
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 64px;
min-height: 40px;
padding-inline: 64px;
box-sizing: border-box;
-webkit-text-decoration: none;
text-decoration: none;
min-height: 40px;
min-width: auto;
min-width: 64px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -2005,6 +2009,7 @@ exports[`Sidebar navigation should render only routes under current section 1`]
border-style: solid;
color: #5A6A79;
cursor: pointer;
width: 100%;
-webkit-box-pack: start;
-ms-flex-pack: start;
-webkit-justify-content: flex-start;
Expand Down Expand Up @@ -2388,6 +2393,7 @@ exports[`Sidebar navigation should render only routes under current section 1`]

.emotion-1>ul {
box-sizing: border-box;
position: relative;
list-style-type: none;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -2430,7 +2436,6 @@ exports[`Sidebar navigation should render only routes under current section 1`]
-ms-flex-align: center;
align-items: center;
padding: 12px 16px;
width: 100%;
min-width: 64px;
min-height: 40px;
-webkit-padding-start: 32px;
Expand All @@ -2439,7 +2444,7 @@ exports[`Sidebar navigation should render only routes under current section 1`]
-webkit-text-decoration: none;
text-decoration: none;
min-height: 40px;
min-width: auto;
min-width: 64px;
cursor: default;
overflow: hidden;
border: none;
Expand All @@ -2454,6 +2459,7 @@ exports[`Sidebar navigation should render only routes under current section 1`]
border-style: solid;
color: #5A6A79;
cursor: pointer;
width: 100%;
-webkit-box-pack: start;
-ms-flex-pack: start;
-webkit-justify-content: flex-start;
Expand Down
Loading