-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(PPDSC-2477): remove sourcepoint component #461
Conversation
You can preview these changes on: |
site/pages/_document.tsx
Outdated
@@ -246,14 +236,14 @@ export default class MyDocument extends Document { | |||
} | |||
`} | |||
/> | |||
{isSiteEnvProduction && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this condition there originally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vanals I see this has been added to remove it for SVG Previewer, do we still need that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rings a bell. I think it breaks a figma plugin or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey! sorry saw this randomly now.
I think the reason was that tealium did break our website from being rendered in a Iframe. This stopped designers from being able to use the previewer. Removing it from dev
allows designers to use the Previewers with no issue, so yeah this should stay I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we move that to _app.tsx and from there we can have access to url "path" and disable it only for preview URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the code
PPDSC-2477
What
What did you do - removed the Consent component, the consent code will be loaded directly from tealium
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: