-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PPDSC-2480): load correct font urls #448
Conversation
- Old Montserrat font link was invalid - Instead of hardcoding the new one, add a link element to load a stylesheet that imports the fonts - This matches what Virgin do on their site
You can preview these changes on: |
<link | ||
rel='stylesheet' | ||
href='https://fonts.googleapis.com/css2?family=Montserrat:ital,wght@0,400;0,600;0,700;1,400;1,700&display=swap' | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to me personally, that's the simplest solution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty neat. How did you find this? @mstuartf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the Virgin site and that's how they load their fonts there. I think the reason that this stopped working is that the old google fonts url was out of date / invalid. But this way we shouldn't have this problem again.
PPDSC-2480
What
Font file not loading for Virgin so incorrect font displaying in Storybook theme checker
Virgin fonts display correctly in theme checker
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: