-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PPDSC-2077): add grid-auto props and stylePreset overrides to GridLayout #447
feat(PPDSC-2077): add grid-auto props and stylePreset overrides to GridLayout #447
Conversation
You can preview these changes on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good!
After #419 is merged, applying stylePreset to gridLayout will result in styles being applied twice as Flag is now using GridLayout. A lot of components are built on top of flag. This result in more than 300 snapshot changes. After chatting with @mutebg , we decided not to add stylePreset to GridLayout overrides for now. |
PPDSC-2077
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: