Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(PPDSC-2471): update DOCKER_TAG to enable deploys from main #427

Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2471

What

Updated DOCKER_TAG in config.yml file to differentiate a dev vs prod vs release builds.

We need this in order to fix the approve_publish_docs_&_storybook step and manually release docs and storybook from main. This is step one of the ticket.
After this gets merged I will test the above step and if it works then I will open another PR for removing that manual step and enable docs deploy on every merge to main.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@evgenitsn evgenitsn added ready for review Please assist in getting this reviewed task A non user facing change labels Oct 21, 2022
@evgenitsn evgenitsn merged commit f7e9d5f into main Oct 21, 2022
@evgenitsn evgenitsn deleted the ci/PPDSC-2471-update-circle-ci-docker-tag-to-deploy-from-main branch October 21, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed task A non user facing change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants