Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2494): fix grid-layout areas with no space #424

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Oct 20, 2022

PPDSC-2494

What

  1. Background - the sun is using templates for grid-layout areas which are without space, which breaks our component. for example, the code below will not work:
const areasWithNoSpace = `
A
B
C
D`;
  1. What did you do
  2. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mutebg mutebg marked this pull request as ready for review October 20, 2022 12:24
@github-actions github-actions bot added the fix This change fixes a bug label Oct 20, 2022
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Oct 20, 2022
@mutebg mutebg changed the title fix(PPDSC-2494): fix areas with no space fix(PPDSC-2494): fix grid-layout areas with no space Oct 21, 2022
@mutebg mutebg merged commit ea8b32b into main Oct 24, 2022
@mutebg mutebg deleted the fix/PPDSC-2494-grid-layoyt-areas-without-space branch October 24, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants