-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(PPDSC-2346): Grid cell documentation #420
Conversation
You can preview these changes on: |
site/pages/components/grid.tsx
Outdated
import {UsageKind} from '../../components/usage-card'; | ||
import {ContentText} from '../../components/text-section/content-text'; | ||
|
||
const commonOverridesRows = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Grid does not have overrides, thtese are just props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mutebg , Overrides has been removed. Please have a look on it. -thanks!
site/pages/components/grid.tsx
Outdated
summary: | ||
'The grid has a range of props that can be used to define an appropriate experience for different use cases.', | ||
propsRows: [ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maxWidth
prop is missing,
type: string
default: 1920px
site/pages/components/grid.tsx
Outdated
summary: `The cell has a range of props that can be used to define an appropriate experience for different use cases.`, | ||
propsRows: [ | ||
{ | ||
name: 'Root', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: 'Root', | |
name: 'children', |
site/pages/components/grid.tsx
Outdated
{ | ||
name: 'xs span', | ||
type: [ | ||
'xsHidden', | ||
'smHidden', | ||
'mdHidden', | ||
'lgHidden', | ||
'xlHidden', | ||
], | ||
default: '', | ||
description: | ||
'The children of a column are rendered in that column, any supported React node is allowed.', | ||
required: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tihs does not seems correct, we have the following props:
xs?: number | 'full-width';
sm?: number | 'full-width';
md?: number | 'full-width';
lg?: number | 'full-width';
xl?: number | 'full-width';
xsHidden?: boolean;
smHidden?: boolean;
mdHidden?: boolean;
lgHidden?: boolean;
xlHidden?: boolean;
xsOrder?: number;
smOrder?: number;
mdOrder?: number;
lgOrder?: number;
xlOrder?: number;
xsOffset?: number;
smOffset?: number;
mdOffset?: number;
lgOffset?: number;
xlOffset?: number;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mutebg ,
All the changes has been done. Please have a look on it.
Thanks,
Rashika
site/pages/components/grid.tsx
Outdated
/> | ||
); | ||
|
||
const commonPropsRows = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const commonPropsRows = [ | |
const gridPropsRows = [ |
site/pages/components/grid.tsx
Outdated
}, | ||
{ | ||
title: 'Cell', | ||
summary: `The cell has a range of props that can be used to define an appropriate experience for different use cases.`, | ||
propsRows: [ | ||
{ | ||
name: 'Root', | ||
name: 'Children', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowercase
name: 'Children', | |
name: 'children', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mutebg ,
changes has been done, Please have a look on it. -thanks!
PPDSC-2346
What
1.Grid-Cell documentation UI.
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: