Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/ppdsc 2445 updated divider stories #411

Merged
merged 13 commits into from
Oct 18, 2022
Merged

docs/ppdsc 2445 updated divider stories #411

merged 13 commits into from
Oct 18, 2022

Conversation

baburay23
Copy link
Contributor

PPDSC-XXXX

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Oct 12, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2445-updated-divider-stories
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2445-updated-divider-stories/storybook

@baburay23 baburay23 changed the title Docs/ppdsc 2445 updated divider stories docs/ppdsc 2445 updated divider stories Oct 12, 2022
@baburay23 baburay23 added ready for design review Please assist in getting this reviewed Requires design review labels Oct 12, 2022
@baburay23 baburay23 added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed Requires design review labels Oct 13, 2022
Vanals
Vanals reviewed Oct 13, 2022
View reviewed changes
src/divider/__tests__/divider.stories.tsx Outdated
import {compileTheme, createTheme} from '../../theme';

const Box = styled.div`
const Box = styled.div<{marginRight?: boolean; transparent?: boolean}>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about isMarginRight ? I think would make it easier to understand is a boolean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats much better thanks for the tip!

@baburay23 baburay23 requested review from evgenitsn and Vanals October 14, 2022 12:18
@mutebg mutebg added the ready for design review Please assist in getting this reviewed label Oct 17, 2022
@baburay23 baburay23 removed the ready for design review Please assist in getting this reviewed label Oct 17, 2022
@baburay23 baburay23 merged commit 55a559b into main Oct 18, 2022
@baburay23 baburay23 deleted the docs/PPDSC-2445-updated-divider-stories branch October 18, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenitsn evgenitsn evgenitsn approved these changes

@Vanals Vanals Vanals approved these changes

@Srinivasan-Ramasamy Srinivasan-Ramasamy Srinivasan-Ramasamy approved these changes

@jps jps Awaiting requested review from jps

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@mutebg mutebg Awaiting requested review from mutebg

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@baburay23 @newskit-engineering @evgenitsn @Vanals @Srinivasan-Ramasamy @mutebg